Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: environment - gather declared license information according to PEP639 #755

Merged
merged 36 commits into from
Jun 10, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jun 8, 2024

From python environments, gather additional declared license information
according to PEP 639 (improving license clarity with better package metadata).

New CLI switches for cyclonedx environment:

  • --PEP-639: Enable license gathering according to PEP 639 (improving license clarity with better package metadata).
    The behavior may change during the draft development of the PEP.
  • --gather-license-texts: Enable license text gathering.

In current state of implementation, --gather-license-texts has effect only if --PEP-639 is also given.

part of #570

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] Feat: env license texts [WIP] Feat: license gathering according to PEP639 Jun 8, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] Feat: license gathering according to PEP639 [WIP] Feat: license gathering from environment according to PEP639 Jun 8, 2024
@jkowalleck jkowalleck added the enhancement New feature or request label Jun 8, 2024
@jkowalleck jkowalleck changed the title [WIP] Feat: license gathering from environment according to PEP639 [WIP] feat: license gathering from environment according to PEP639 Jun 8, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] feat: license gathering from environment according to PEP639 [WIP] feat: declared license information according to PEP639 Jun 9, 2024
@jkowalleck jkowalleck changed the title [WIP] feat: declared license information according to PEP639 [WIP] feat: environment - gather declared license information according to PEP639 Jun 9, 2024
@jkowalleck jkowalleck self-assigned this Jun 9, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Copy link

codacy-production bot commented Jun 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.08% (target: -1.00%) 94.59% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cba521e) 1034 1001 96.81%
Head commit (1cd1ef6) 1070 (+36) 1035 (+34) 96.73% (-0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#755) 37 35 94.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [WIP] feat: environment - gather declared license information according to PEP639 feat: environment - gather declared license information according to PEP639 Jun 10, 2024
@jkowalleck jkowalleck marked this pull request as ready for review June 10, 2024 10:56
@jkowalleck jkowalleck requested a review from a team as a code owner June 10, 2024 10:56
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit e9cc805 into main Jun 10, 2024
34 checks passed
@jkowalleck jkowalleck deleted the feat/env-license-texts branch June 10, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant