Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: populate properties cdx:python:package:source:vcs:... #790

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Sep 18, 2024

populate the newly added/fixed CycloneDX properties cdx:python:package:source:vcs:... in accordance with CycloneDX/cyclonedx-property-taxonomy#96 and CycloneDX/cyclonedx-property-taxonomy#98.

the deprecated properties are still used, so no breaking changes exist.

fixes #789

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the enhancement New feature or request label Sep 18, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner September 18, 2024 17:36
Copy link

codacy-production bot commented Sep 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 93.75% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a1354e5) 1070 1035 96.73%
Head commit (55e9e25) 1075 (+5) 1040 (+5) 96.74% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#790) 16 15 93.75%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title feat: populate added properties of cdx:python:vcs:... feat: populate added properties of cdx:python:package:source:... Sep 18, 2024
@jkowalleck jkowalleck changed the title feat: populate added properties of cdx:python:package:source:... feat: populate properties cdx:python:package:source:vcs:... Sep 20, 2024
@jkowalleck jkowalleck merged commit b08e1bb into main Sep 20, 2024
34 checks passed
@jkowalleck jkowalleck deleted the feat/property_cdx-python-package branch September 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: populate added properties of cdx:python:package:source:...
1 participant