Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing of empty XML string tags #761

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

justahero
Copy link
Contributor

This adds support to parse either

<description>something</description>

or an empty XML tag.

<description />

The latter XML tag is an empty string (equivalent to <description></description>).

  • fix read_simple_tag function to allow to parse empty XML tags
  • add documentation
  • add test sample with an empty <description> tag

Closes #738

@justahero justahero requested a review from a team as a code owner August 7, 2024 14:22
This adds support to parse

```xml
<description>something</description>
```

&

```xml
<description />
```

The latter XML tag is an empty string (equivalent to `<description></description>`).

* fix `read_simple_tag` function to allow to parse empty XML tags
* add documentation
* add test sample with an empty description tag

Signed-off-by: Sebastian Ziebell <sebastian.ziebell@ferrous-systems.com>
@justahero justahero force-pushed the fix-read-description-tag-xml branch from 46cb72e to 635e4f0 Compare August 7, 2024 14:22
@Shnatsel Shnatsel merged commit 7596551 into CycloneDX:main Aug 7, 2024
13 checks passed
@Shnatsel
Copy link
Contributor

Shnatsel commented Aug 7, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML deserialization of empty tags is incorrect
2 participants