You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tools\src\test\resources\1.6 contains many valid BOMs in all three serialization formats (JSON, xml, textproto). However, in many cases their content varies in the three different forms. I would like to ensure that they represent the same content (as much as possible).
This would allow to test whether implementations support the three formats correctly (see for instance CycloneDX/cyclonedx-dotnet-library#331). This allowed me in particular to identify several issues in the cyclonedx-dotnet-library implementation.
If possible, this should also be respected when adding new samples in the future.
Possible solutions
Adjust the test sample files (using in most cases the JSON files as reference). (This applies only to the valid files that are available in the three formats.)
Alternatives
We could also add adjusted samples to the implementation repos (like cyclonedx-dotnet-library). However, this would lead to quite some duplication.
Additional context
The three format have slight differences, thus it might not be 100% semantically equivalent. However, the samples also highlight some inconsistences (and thus could also help to avoid future inconsistencies). One difference is for instance that the proto format does not distinguish between an empty list and a null value.
The text was updated successfully, but these errors were encountered:
jkowalleck
changed the title
[FEATURE]: The test sample BOMs in the different formats should be consistent
[TESTS]: The test sample BOMs in the different formats should be consistent
Sep 2, 2024
Describe the feature
tools\src\test\resources\1.6
contains many valid BOMs in all three serialization formats (JSON, xml, textproto). However, in many cases their content varies in the three different forms. I would like to ensure that they represent the same content (as much as possible).This would allow to test whether implementations support the three formats correctly (see for instance CycloneDX/cyclonedx-dotnet-library#331). This allowed me in particular to identify several issues in the cyclonedx-dotnet-library implementation.
If possible, this should also be respected when adding new samples in the future.
Possible solutions
Adjust the test sample files (using in most cases the JSON files as reference). (This applies only to the valid files that are available in the three formats.)
Alternatives
We could also add adjusted samples to the implementation repos (like cyclonedx-dotnet-library). However, this would lead to quite some duplication.
Additional context
The three format have slight differences, thus it might not be 100% semantically equivalent. However, the samples also highlight some inconsistences (and thus could also help to avoid future inconsistencies). One difference is for instance that the proto format does not distinguish between an empty list and a null value.
The text was updated successfully, but these errors were encountered: