Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt test samples to ensure consistency between the different formats #514

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

andreas-hilti
Copy link
Contributor

Closes: #513

@andreas-hilti andreas-hilti requested a review from a team as a code owner August 31, 2024 22:16
@andreas-hilti andreas-hilti marked this pull request as draft August 31, 2024 22:23
@andreas-hilti andreas-hilti force-pushed the consistent_samples branch 3 times, most recently from e417920 to 7feee4b Compare August 31, 2024 22:57
@andreas-hilti
Copy link
Contributor Author

andreas-hilti commented Aug 31, 2024

At the moment, with all fixes to the library, only 2 of the consistency checks in CycloneDX/cyclonedx-dotnet-library#331 fail:

@jkowalleck jkowalleck added the test-data related to test-resources and -data label Sep 2, 2024
@andreas-hilti andreas-hilti force-pushed the consistent_samples branch 2 times, most recently from 2d149fa to f7daca7 Compare September 14, 2024 15:41
@jkowalleck
Copy link
Member

the blocking issues were solved.
feel free to rebase/merge, your work is appreciated very much.

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
@andreas-hilti andreas-hilti marked this pull request as ready for review November 7, 2024 21:37
@andreas-hilti
Copy link
Contributor Author

@jkowalleck Like this all the consistency tests would be passing.
Do you know why the Java test are failing? (I didn't touch valid-standard-1.6.xml nor valid-component-data-1.6.xml; but I see that it fails also on master.)

@jkowalleck
Copy link
Member

Do you know why the Java test are failing?

we've updated the XML schema, and it is not reflected by the java tests due to #256

@jkowalleck
Copy link
Member

jkowalleck commented Nov 18, 2024

received no negative feedback from community.
so we assume all are cool with the proposed changes to the test data.

thank you for your contribution, @andreas-hilti !

@jkowalleck jkowalleck merged commit db041a4 into CycloneDX:master Nov 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review test-data related to test-resources and -data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TESTS]: The test sample BOMs in the different formats should be consistent
2 participants