Skip to content

[Defect]: Missing type in XML schema for ComponentData subelements #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreas-hilti opened this issue Feb 21, 2025 · 1 comment · May be fixed by #511
Closed

[Defect]: Missing type in XML schema for ComponentData subelements #600

andreas-hilti opened this issue Feb 21, 2025 · 1 comment · May be fixed by #511

Comments

@andreas-hilti
Copy link
Contributor

andreas-hilti commented Feb 21, 2025

Describe the defect

In the XML schema, "sensitiveData" is not specified as a particular type. I believe it should be specified as "xs:string", to be consistent with the JSON and protobuf schemas.
The same applies also to "description" of "graphics".

More in details:
sensitiveData is defined as:

<xs:element name="sensitiveData" minOccurs="0" maxOccurs="unbounded">

According to https://www.w3.org/TR/xmlschema-0/#anyType:

The content of the element declared in this way is unconstrained, so the element value may be 423.46, but it may be any other sequence of characters as well, or indeed a mixture of characters and elements. In fact, anyType is the default type when none is specified, [...]

if no type is specified, it is anyType and not string.

This is the JSON equivalent:

"sensitiveData": {
"type": "array",
"title": "Sensitive Data",
"description": "A description of any sensitive data included.",
"items": {
"type": "string"
}
},

Similar issue is here:

<xs:element name="description" minOccurs="0" maxOccurs="1">

Additional context

n/a

@jkowalleck
Copy link
Member

thank you for the report and the fix, @andreas-hilti 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants