fix json-schema-file strict schema property #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalleck
commented
Sep 17, 2022
| @@ -12,10 +12,7 @@ | |||
| "additionalProperties": false, | |||
| "properties": { | |||
| "$schema": { | |||
| "type": "string", | |||
| "enum": [ | |||
| "http://cyclonedx.org/schema/bom-1.2a.schema.json" | |||
There was a problem hiding this comment.
was in conflict with the own $id
jkowalleck
commented
Sep 17, 2022
| @@ -12,10 +12,7 @@ | |||
| "additionalProperties": false, | |||
| "properties": { | |||
| "$schema": { | |||
| "type": "string", | |||
| "enum": [ | |||
| "http://cyclonedx.org/schema/bom-1.3.schema.json" | |||
There was a problem hiding this comment.
was in conflict with the own $id
4 tasks
|
Will need to take a vote. Another possibility would be to leave the enum in place and have a unit test that checks. |
jkowalleck
force-pushed
the
fix/json--strict_property_schema
branch
from
c6e44a0 to
1684976
Compare
|
updated for CDX 1.5 |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
fix/json--strict_property_schema
branch
from
1684976 to
f3631ee
Compare
|
obsoleted by #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @stevespringett ,
looks like there is a bug in the strict schema files: the optional
bom.$schemaproperty was not updated, when the actual schema$idrevision was bumped.to mitigate this for now and the future, i propose to lax the definition - from a specific string to any string.
This means: no need to modify the schema version on multiple places, when bumping.