Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for license acknowledgements #408

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Added support for license acknowledgements #408

merged 3 commits into from
Mar 28, 2024

Conversation

stevespringett
Copy link
Member

@stevespringett stevespringett commented Mar 22, 2024 •
edited by jkowalleck
Loading

Closes #407

  • modify JSON schema
  • modify XML schema
  • modify protobuf schema
  • add examples & test resources

@stevespringett
Added support for license acknowledgements
b870a93 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett stevespringett added this to the 1.6 milestone Mar 22, 2024
@stevespringett stevespringett requested a review from a team as a code owner March 22, 2024 22:58
@stevespringett
Fixed unit tests
74803ec 
Signed-off-by: Steve Springett <steve@springett.us>
jkowalleck
jkowalleck requested changes Mar 23, 2024
View reviewed changes
schema/bom-1.6.proto Outdated Show resolved Hide resolved
@jkowalleck jkowalleck linked an issue Mar 23, 2024 that may be closed by this pull request
Add support for license acknowledgements #407
Closed
@stevespringett
Updated comment
83691a6 
Signed-off-by: Steve Springett <steve@springett.us>
@jkowalleck jkowalleck requested a review from a team March 23, 2024 21:23
@stevespringett stevespringett added promote to tc54 Promote to Ecma Technical Committee 54 tc54 reviewed Ecma TC54 has reviewed the feature candidate tc54 accepted Ecma TC54 has accepted the feature candidate labels Mar 28, 2024
@stevespringett stevespringett merged commit fc55713 into 1.6-dev Mar 28, 2024
8 checks passed
@jkowalleck jkowalleck mentioned this pull request Mar 29, 2024
Merged
@mr-zepol mr-zepol mentioned this pull request Apr 7, 2024
Merged
stevespringett added a commit that referenced this pull request Apr 9, 2024
@stevespringett
[WIP] v1.6 (#323)
c5032b8 
## Added

* Core enhancement: Attestation
([#192](#192) via
[#348](#348))
* Core enhancement: Cryptography Bill of Materials — CBOM
([#171](#171),
[#291](#291) via
[#347](#347))
* Feature to express the URL to source distribution
([#98](#98) via
[#269](#269))
* Feature to express the URL to RFC 9116 compliant documents
([#380](#380) via
[#381](#381))
* Feature to express tags/keywords for services and components (via
[#383](#383))
* Feature to express details for component authors
([#335](#335) via
[#379](#379))
* Feature to express details for component and BOM manufacturer
([#346](#346) via
[#379](#379))
* Feature to express communicate concluded values from observed
evidences ([#411](#411)
via [#412](#412))
* Features to express license acknowledgement
([#407](#407) via
[#408](#408))
* Feature to express environmental consideration information for model
cards ([#396](#396) via
[#395](#395))
* Feature to express the address of organizational entities (via
[#395](#395))
* Feature to express additional component identifiers: Universal Bill Of
Receipts Identifier and Software Heritage persistent IDs
([#413](#413) via
[#414](#414))

## Fixed

* Allow multiple evidence identities by XML/JSON schema
([#272](#272) via
[#359](#359))
  This was already correct via ProtoBuff schema.
* Prevent empty `license` entities by XML schema
([#288](#288) via
[#292](#292))
  This was already correct in JSON/ProtoBuff schema.
* Prevent empty or malformed `property` entities by JSON schema
([#371](#371) via
[#375](#375))
  This was already correct in XML/ProtoBuff schema.
* Allow multiple `licenses` in `Metadata` by ProtoBuff schema
([#264](#264) via
[#401](#401))
  This was already correct in XML/JSON schema.

## Changed

* Allow arbitrary `$schema` values by JSON schema
([#402](#402) via
[#403](#403))
* Increased max length of `versionRange` (via
[`3e01ce6`](3e01ce6))
* Harmonized length of `version` (via
[#417](#417))

## Deprecated

* Data model "Component"'s field `author` was deprecated. (via
[#379](#379))
  Use field `authors` or field `manufacturer` instead.
* Data model "Metadata"'s field `manufacture` was deprecated.
([#346](#346) via
[#379](#379))
  Use "Metadata"'s field `component`'s field `manufacturer` instead. 
  - for XML: `/bom/metadata/component/manufacturer`
  - for JSON: `$.metadata.component.manufacturer`
  - for ProtoBuf: `Bom:metadata.component.manufacturer`

## Documentation

* Centralize version and version-range (via
[#322](#322))
* Streamlined SPDX expression related descriptions (via
[#327](#327))
* Enhanced descriptions of `bom-ref`/`refType`
([#336](#336) via
[#344](#344))
* Enhanced readability of enum documentation in JSON schema
([#361](#361) via
[#362](#362))
* Fixed typo "compliment" -> "complement" (via
[#369](#369))
* Added documentation for enum "ComponentScope"'s values in JSON schema
([#293](#293) via
[`d92e58e`](d92e58e))
  Texts were a taken from the existing ones in XML/ProtoBuff schema.
* Added documentation for enum "TaskType"'s values
([#245](#245) via
[#377](#377))
* Improve documentation for data model "Metadata"'s field `licenses`
([#273](#273) via
[#378](#378))
* Added documentation for enum "MachineLearningApproachType"'s values
([#351](#351) via
[#416](#416))
* Rephrased some texts here and there.

## Test data

* Added test data for newly added use cases
* Added quality assurance for our ProtoBuf schemas
([#384](#384) via
[#385](#385))
@stevespringett stevespringett deleted the 1.6-dev-license-ack branch April 9, 2024 05:22
@mcombuechen mcombuechen mentioned this pull request May 16, 2024
Closed
@andreas-hilti andreas-hilti mentioned this pull request Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalleck jkowalleck jkowalleck approved these changes

Assignees
No one assigned
Labels
promote to tc54 Promote to Ecma Technical Committee 54 proposed core enhancement tc54 accepted Ecma TC54 has accepted the feature candidate tc54 reviewed Ecma TC54 has reviewed the feature candidate
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Add support for license acknowledgements
2 participants
@stevespringett @jkowalleck