Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Streebog hashing algorithm #525

Open
wants to merge 3 commits into
base: 1.7-dev
Choose a base branch
from
Open

Add support for Streebog hashing algorithm #525

wants to merge 3 commits into from

Conversation

volkdm
Copy link

@volkdm volkdm commented Sep 26, 2024 •
edited by jkowalleck
Loading

fixes #485

@volkdm volkdm requested a review from a team as a code owner September 26, 2024 14:03
@jkowalleck jkowalleck added this to the 1.7 milestone Sep 26, 2024
@jkowalleck jkowalleck linked an issue Sep 26, 2024 that may be closed by this pull request
[FEATURE]: Adding Streebog hashing algorithm #485
Open
jkowalleck
jkowalleck requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@jkowalleck jkowalleck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write the name "Streebog", not in all caps "STREEBOG".
Unlike SHA or BLAKE, Streebog is not an abbreviation, but a name.

PS: done via fec8c4c

@jkowalleck jkowalleck changed the title Add support for STREEBOG hashing algorithm Add support for Streebog hashing algorithm Sep 26, 2024
jkowalleck
jkowalleck requested changes Sep 26, 2024
View reviewed changes
schema/bom-1.7.schema.json Outdated Show resolved Hide resolved
schema/bom-1.7.xsd Outdated Show resolved Hide resolved
schema/bom-1.7.proto Outdated Show resolved Hide resolved
@volkdm
Add "HASH_ALG_" prefix to algorithm name
1d0a1d5 
Signed-off-by: Dmitry Volk <volk.dmitry@gmail.com>
@volkdm
Fix hashing algorithm name, because Streebog is not an abbreviation, …
fec8c4c 
…but a name.

Signed-off-by: Dmitry Volk <volk.dmitry@gmail.com>
@volkdm volkdm requested a review from jkowalleck September 26, 2024 15:08
@jkowalleck jkowalleck requested review from stevespringett and a team September 26, 2024 15:18
@stevespringett stevespringett added the RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration label Oct 1, 2024
@stevespringett
Copy link
Member

The official RFC notice has been published and will be open until October 28. If approved, it will be promoted to Ecma TC54.

@stevespringett stevespringett added tc54 reviewed Ecma TC54 has reviewed the feature candidate tc54 accepted Ecma TC54 has accepted the feature candidate labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevespringett stevespringett stevespringett approved these changes

@jkowalleck jkowalleck jkowalleck approved these changes

Assignees
No one assigned
Labels
proposed core enhancement request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration tc54 accepted Ecma TC54 has accepted the feature candidate tc54 reviewed Ecma TC54 has reviewed the feature candidate
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Adding Streebog hashing algorithm
3 participants
@volkdm @stevespringett @jkowalleck