Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Github releases for upgraded version, instead of crates.io #647

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Check Github releases for upgraded version, instead of crates.io #647

merged 2 commits into from
Aug 5, 2024

Conversation

alexroan
Copy link
Contributor

@alexroan alexroan commented Aug 3, 2024

  • Check new version tags from Github releases, rather than crates.io.
  • Add a warning in the crate README.

@alexroan alexroan requested a review from TilakMaddy August 3, 2024 18:26
@TilakMaddy
Copy link
Contributor

This looks good. But for existing cargo installers, do we create a separate branch just for 1 release where we tell them about cyfrinup ?

@alexroan
Copy link
Contributor Author

alexroan commented Aug 4, 2024 •
edited
Loading

Good idea. in a follow up branch:

  1. create a big warning after every run to use cyfrinup instead of cargo.
  2. publish the package to crates.io
  3. yank old versions from crates.io.

Are you happy to approve this one @TilakMaddy so I can merge it?

TilakMaddy
TilakMaddy approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@TilakMaddy TilakMaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please !! @alexroan

@alexroan alexroan merged commit dcefbea into dev Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TilakMaddy TilakMaddy TilakMaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexroan @TilakMaddy