Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't report issues with no instances (after aderyn ignore was introduced) #681

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

TilakMaddy
Copy link
Contributor

After running through ignore lines, if there are 0 issues, then don't include it in report

@TilakMaddy TilakMaddy changed the title Fix: Don't allow empty issues with no instances Fix: Don't report issues with no instances (after aderyn ignore was introduced) Aug 19, 2024
@TilakMaddy TilakMaddy marked this pull request as ready for review August 19, 2024 11:35
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner August 19, 2024 11:35
@TilakMaddy TilakMaddy added the priority-high High priority Issue - Tackle this first. label Aug 26, 2024
aderyn_core/src/lib.rs Show resolved Hide resolved
@TilakMaddy
Copy link
Contributor Author

Waiting for #704 to get in, so I can write higher quality tests

reports/empty_report.md Outdated Show resolved Hide resolved
@alexroan alexroan merged commit a93f585 into dev Sep 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-high High priority Issue - Tackle this first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants