Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector: Missing Inheritance #701

Merged
merged 14 commits into from
Sep 2, 2024
Merged

Detector: Missing Inheritance #701

merged 14 commits into from
Sep 2, 2024

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Aug 24, 2024

Severity: Low

Qualifications: All solc versions

Logic:

For every non abstract contract c which doesn't inherit from any other contract: 
        Check if there is  any abstract contract or interface  i  whose linearized base chain shares all the function selectors with c:
             Report i as missing inheritance of c 

When such a contract is found, report it

@TilakMaddy TilakMaddy marked this pull request as ready for review August 24, 2024 07:33
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner August 24, 2024 07:33
@TilakMaddy TilakMaddy marked this pull request as draft August 31, 2024 06:32
@TilakMaddy

This comment was marked as resolved.

@TilakMaddy TilakMaddy marked this pull request as ready for review August 31, 2024 07:55
@TilakMaddy TilakMaddy marked this pull request as draft September 2, 2024 05:51
@TilakMaddy TilakMaddy marked this pull request as ready for review September 2, 2024 06:12
@alexroan alexroan merged commit 88f6833 into dev Sep 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants