Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Enhancement) Add AsciiArt Install Banner #718

Merged
merged 2 commits into from
Sep 22, 2024
Merged

(Enhancement) Add AsciiArt Install Banner #718

merged 2 commits into from
Sep 22, 2024

Conversation

xyizko
Copy link
Contributor

@xyizko xyizko commented Sep 13, 2024

Description

  1. The installation of the tool doesnt have a prominent eye catching indicator of what it is. To remedy that an ascii art banner has been added.
  2. The aderyn logo has been converted to ascii art and is of minimal size such that fidelity is not completely lost

AI Usage

  1. Determining the optimal position of placing the banner function so that they are registered during execution.

@xyizko
(Enhancement) Add AsciiArt Install Banner
415ad80 
- Banners have been added to ./install and ./cyfrinup
@xyizko xyizko requested a review from alexroan as a code owner September 13, 2024 19:09
@TilakMaddy
Copy link
Contributor

Hmm ... We plan on having more tools installed in the future on cyfrinup (not just aderyn)

alexroan
alexroan approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@alexroan alexroan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely addition! Thank you @xyizko

@alexroan alexroan merged commit 3ed9e4b into Cyfrin:dev Sep 22, 2024
6 checks passed
@xyizko xyizko deleted the add-asciiart-install-banner branch September 22, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexroan alexroan alexroan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xyizko @TilakMaddy @alexroan