Rename ConstantsInsteadOfLiterals
detector to better suit //aderyn-ignore-(..)
#737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Problem:
It doesn't make sense to ignore the fact that constants are being used instead of literals
Other examples: we say
aderyn-ignore-next-line(empty-block)
.. we don't sayaderyn-ignore-next-line(filled-block)
We state the problem in the detector's name
So I have renamed this
Now it reads, "ignore the fact that it's a literal instead of a constant"
`