fix: sign txn result param

Cypherock · Nov 29, 2024 · 67b0867 · 67b0867
1 parent 78db231
commit 67b0867
Show file tree

Hide file tree

Showing 5 changed files with 4,695 additions and 6,490 deletions.
diff --git a/packages/app-starknet/src/operations/signTxn/index.ts b/packages/app-starknet/src/operations/signTxn/index.ts
@@ -2,7 +2,6 @@ import { ISDK } from '@cypherock/sdk-core';
 import {
   createStatusListener,
   assert,
-  hexToUint8Array,
   uint8ArrayToHex,
   createLoggerWithPrefix,
 } from '@cypherock/sdk-utils';
@@ -13,7 +12,6 @@ import {
 } from '../../proto/generated/types';
 import {
   assertOrThrowInvalidResult,
-  getStarknetApiJs,
   OperationHelper,
   logger as rootLogger,
 } from '../../utils';
@@ -64,11 +62,8 @@ export const signTxn = async (
   assertOrThrowInvalidResult(confirmResponse.confirmation);
   forceStatusUpdate(SignTxnEvent.CONFIRM);
 
-  const txnBytes = hexToUint8Array(params.txn);
   await helper.sendQuery({
-    txn: {
-      txn: txnBytes,
-    },
+    txn: params.txn,
   });
 
   const accepted = await helper.waitForResult();
@@ -83,12 +78,10 @@ export const signTxn = async (
 
   forceStatusUpdate(SignTxnEvent.PIN_CARD);
 
-  const key = uint8ArrayToHex(result.signature.signature);
-  const starknet = getStarknetApiJs();
-  const signature = starknet.ec.starkCurve.sign(params.txn, key.slice(0, 64));
+  const signature = uint8ArrayToHex(result.signature.signature);
 
   return {
-    signature: signature.toCompactHex(),
-    serializedTxn: signature.toCompactHex(),
+    signature,
+    serializedTxn: signature,
   };
 };
diff --git a/packages/app-starknet/src/operations/signTxn/types.ts b/packages/app-starknet/src/operations/signTxn/types.ts
@@ -1,3 +1,5 @@
+import { ISignTxnUnsignedTxn } from '../../proto/generated/types';
+
 export enum SignTxnEvent {
   INIT = 0,
   CONFIRM = 1,
@@ -13,7 +15,7 @@ export interface ISignTxnParams {
 
   walletId: Uint8Array;
   derivationPath: number[];
-  txn: string;
+  txn: ISignTxnUnsignedTxn;
 }
 
 export interface ISignTxnResult {