Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bitcoin sign transaction #52

Merged
merged 9 commits into from
Aug 9, 2023

Conversation

ujjwal-cyph
Copy link
Contributor

@ujjwal-cyph ujjwal-cyph commented Aug 1, 2023

the changeset targets bitcoin package with following changes

  • update proto message and related changes
  • conditionally fetch previous raw txn from web API call
  • prepare signed transaction with signature
  • updated tests with real transaction data
  • adds 2 new dependencies: axios and bip66

partly replaces #51

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

🦋 Changeset detected

Latest commit: 3bf81f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypherock/sdk-app-btc Patch
browser-test Patch
nodejs-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ujjwal-cyph ujjwal-cyph force-pushed the feat/btc-sign-transactions branch from 8980e19 to e92affa Compare August 8, 2023 13:03
@ujjwal-cyph ujjwal-cyph force-pushed the feat/btc-sign-transactions branch from f318752 to 17df3e4 Compare August 9, 2023 11:19
@ujjwal-cyph ujjwal-cyph changed the title feat: Bitcoin sign transaction refactor: Bitcoin sign transaction Aug 9, 2023
@irshadCypherock irshadCypherock merged commit 4375dba into main Aug 9, 2023
@irshadCypherock irshadCypherock deleted the feat/btc-sign-transactions branch August 9, 2023 13:44
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
ParnikaGupta9 pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants