Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful failure states #774

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Graceful failure states #774

merged 3 commits into from
Apr 17, 2019

Conversation

MatthewTighe
Copy link
Collaborator

Describe the pull request

This PR moves the mapping of IllegalState to resource ids to a Utility class, where it also uses silent exception logging. This allows us to continue receiving reports without causing the user to crash.

Link to relevant issues
N/A

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #774 into master will increase coverage by 1.47%.
The diff coverage is 73.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #774      +/-   ##
============================================
+ Coverage      36.2%   37.68%   +1.47%     
- Complexity      315      335      +20     
============================================
  Files            40       41       +1     
  Lines          2842     2850       +8     
  Branches        523      528       +5     
============================================
+ Hits           1029     1074      +45     
+ Misses         1684     1640      -44     
- Partials        129      136       +7
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/tech/ula/utils/Extensions.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
app/src/main/java/tech/ula/MainActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
app/src/main/java/tech/ula/utils/AndroidUtility.kt 14.41% <0%> (-0.07%) 0 <0> (ø)
...rc/main/java/tech/ula/utils/IllegalStateHandler.kt 88.23% <88.23%> (ø) 21 <21> (?)
...ava/tech/ula/model/repositories/AssetRepository.kt 81.15% <0%> (-1.45%) 22% <0%> (-1%)
...ain/java/tech/ula/model/state/SessionStartupFsm.kt 83.95% <0%> (-0.62%) 37% <0%> (ø)
...n/java/tech/ula/viewmodel/MainActivityViewModel.kt 89.06% <0%> (+0.78%) 82% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9e89f...5aea94d. Read the comment docs.

@MatthewTighe MatthewTighe merged commit aff408f into master Apr 17, 2019
@MatthewTighe MatthewTighe deleted the graceful-failure-states branch May 9, 2019 21:06
MatthewTighe added a commit that referenced this pull request Aug 14, 2019
* Silently handle failures.

* Update illegal state message.

* Change resource name so translations will be out of date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants