Automate github releases. #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luongthomas
requested changes
May 7, 2019
.circleci/config.yml
Outdated
| export_github_release_token: &export_github_release_token | ||
| run: | ||
| name: Export Github release key | ||
| command echo 'export GITHUB_RELEASE_TOKEN="$GITHUB_RELEASE_TOKEN"' >> $BASH_ENV |
There was a problem hiding this comment.
I think this is missing a colon at the end of command which is leading to CircleCI not building
There was a problem hiding this comment.
Yep, you were right
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
===========================================
- Coverage 37.63% 37.6% -0.04%
- Complexity 335 336 +1
===========================================
Files 41 41
Lines 2851 2851
Branches 528 528
===========================================
- Hits 1073 1072 -1
Misses 1643 1643
- Partials 135 136 +1
Continue to review full report at Codecov.
|
luongthomas
approved these changes
May 7, 2019
MatthewTighe
pushed a commit
that referenced
this pull request
Aug 14, 2019
* Automate github releases. * Fix circleci variable. * Fix command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR will add a step to our automated deployment that will also release the apk to Github as a new release with the same changelogs as what is being sent to the playstore.
Link to relevant issues
N/A