Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and use translatable string resources for download failure reasons. #814

Merged
merged 3 commits into from
May 8, 2019

Conversation

MatthewTighe
Copy link
Collaborator

Describe the pull request

This PR changes the download failure reasons to be string resources.

Link to relevant issues
N/A

@MatthewTighe MatthewTighe requested a review from luongthomas May 8, 2019 18:58
@MatthewTighe MatthewTighe changed the title Download failure string resources Create and use translatable string resources for download failure reasons. May 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #814 into master will increase coverage by 0.04%.
The diff coverage is 30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #814      +/-   ##
============================================
+ Coverage      37.6%   37.64%   +0.04%     
- Complexity      335      336       +1     
============================================
  Files            41       41              
  Lines          2851     2850       -1     
  Branches        528      523       -5     
============================================
+ Hits           1072     1073       +1     
- Misses         1643     1646       +3     
+ Partials        136      131       -5
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/tech/ula/MainActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...rc/main/java/tech/ula/utils/IllegalStateHandler.kt 100% <100%> (+12.24%) 21 <1> (ø) ⬇️
...ain/java/tech/ula/model/state/SessionStartupFsm.kt 83.95% <100%> (-0.62%) 37 <0> (ø)
...n/java/tech/ula/viewmodel/MainActivityViewModel.kt 88.37% <100%> (ø) 82 <0> (ø) ⬇️
...pp/src/main/java/tech/ula/utils/DownloadUtility.kt 86.04% <50%> (ø) 19 <0> (ø) ⬇️
app/src/main/java/tech/ula/utils/AndroidUtility.kt 14.79% <9.52%> (+0.44%) 0 <0> (ø) ⬇️
...ava/tech/ula/model/repositories/AssetRepository.kt 82.6% <0%> (+1.44%) 23% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f040425...7bfac2d. Read the comment docs.

@MatthewTighe MatthewTighe merged commit e0a4549 into master May 8, 2019
@MatthewTighe MatthewTighe deleted the download-failure-string-resources branch May 9, 2019 21:06
MatthewTighe pushed a commit that referenced this pull request Aug 14, 2019
…sons. (#814)

* Create and use string resources for download failures.

* Change localization to interface to better capture in code the translation.

* Remove extraneous start of comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants