Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSE-14] Display new errors and warnings in the CLI #17

Merged
merged 3 commits into from
Mar 15, 2019
Merged

[CSE-14] Display new errors and warnings in the CLI #17

merged 3 commits into from
Mar 15, 2019

Conversation

decarboxy
Copy link
Collaborator

@decarboxy decarboxy commented Mar 14, 2019 •
edited
Loading

This PR is open against #16 for review, it should be merged into rc

Here, we prettyprint the errors and warnings added in #16 into a table. the table looks like this:
Screen Shot 2019-03-14 at 4 33 16 PM

@decarboxy decarboxy changed the title [CSE-14 [CSE-14] Display new errors and warnings in the CLI Mar 14, 2019
javierbq
javierbq approved these changes Mar 15, 2019
View reviewed changes
Copy link

@javierbq javierbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@decarboxy decarboxy merged commit befb551 into CSE-13 Mar 15, 2019
@decarboxy
Copy link
Collaborator Author

i merged this into the wrong branch, ugh

@decarboxy decarboxy mentioned this pull request Mar 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierbq javierbq javierbq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decarboxy @javierbq