Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Microsoft.Extensions.Hosting 3.0.0 #202

Merged
merged 3 commits into from
Oct 3, 2019

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented Oct 2, 2019

When a project is running MagicOnion.Hosting with Microsoft.Extensions.Hosting 3.0.0, MagicOnionHost.CreateDefaultBuilder throws exception.

Because, Microsoft.Extensions.Hosting 3.0.0 deprecated IHostingEnvironment and changed HostingEnvironment property type of HostBuilderContext. As a result, MagicOnionHost is incompatible with Microsoft.Extensions.Hosting 3.0.0.

Fix compatibility with Microsoft.Extensions.Hosting 3.0.0
@mayuki mayuki requested a review from neuecc October 2, 2019 02:46
@neuecc neuecc merged commit a4243d2 into master Oct 3, 2019
@neuecc neuecc deleted the CompatibleWith3.0 branch October 3, 2019 03:42
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants