Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReturnStatusException deserializing when using MemoryPack seriali… #650

Closed
wants to merge 2 commits into from

Conversation

hegi25
Copy link

@hegi25 hegi25 commented May 30, 2023

Fixing StreamingHubClient to force use MessagePack serializer to deserialize ReturnStatusException message when using MemoryPack as default serializer.

@mayuki
Copy link
Member

mayuki commented Jun 2, 2023

Thanks for your PR and contribution.
We have investigated the problem and it seems that the server serialization was not as expected, which caused the bug.

We will fix the server and close this PR. We apologize and thank you for submitting the PR!

@mayuki
Copy link
Member

mayuki commented Jun 5, 2023

We have now released v5.1.8. Thanks!
https://github.com/Cysharp/MagicOnion/releases/tag/5.1.8

@mayuki mayuki closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants