Update streaminghub/getting-started.md#990
Conversation
| room.All.OnLeave(userName); | ||
| await room.RemoveAsync(Context); |
There was a problem hiding this comment.
I thought RemoveAsync should be called first here, but I left it as is.
By the way, in the implementation of samples/ChatApp, RemoveAsync is called first.
MagicOnion/samples/ChatApp/ChatApp.Server/ChatHub.cs
Lines 40 to 41 in e79d6de
|
Thank you for the PR!
|
|
Thank you for the confirmation. I agree that the suggested name is more intuitive and easier to understand. However, if we change the name, I believe the sample implementation should also be revised accordingly. What are your thoughts on this approach? |
|
Ah, I see. I hadn't considered this article and ChatApp to be the same thing. |
I see. That said, I personally believe there’s no downside to keeping interface definitions consistent. |
3a68b32 to
11e5d9a
Compare
|
I’ve made the fix. |
|
Thanks! |
Co-authored-by: mayuki <9012+mayuki@users.noreply.github.com>
…docs Sync PR #990 fix to Japanese and Korean documentation
I thought some parts of streaminghub/getting-started.md could be incorrect, so I made some adjustments.