Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function pointer parameters now has names #40

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

KoolieAid
Copy link
Contributor

@KoolieAid KoolieAid commented Aug 26, 2023

Basically function pointers such as extern "C" fn(i32), the parameter doesn't have names.
In order to fix such issue, I used the alphabet to represent order

escape_name could be removed and directly put the name there since its just a-z.
although im not sure if it will break something, so i left it there

@KoolieAid KoolieAid changed the title Function pointer parameterss now has names Function pointer parameters now has names Aug 26, 2023
@KoolieAid
Copy link
Contributor Author

could also go for arg1, arg2, arg3, ..., for readability instead of 1 character names

let me know if it needs changes

@neuecc
Copy link
Member

neuecc commented Sep 4, 2023

thank you for contribution,
but your code overwrite existing parameter name.

image

I'll merge this PR but fix above issue and change to arg1, arg2, arg3... as you suggested.
thanks!

@neuecc neuecc merged commit fe5b83c into Cysharp:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing argument names for generated function pointers / delegates
2 participants