Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate buildings when load saved game #892

Closed
iaGuoZhi opened this issue May 3, 2022 · 1 comment · Fixed by #1026
Closed

Duplicate buildings when load saved game #892

iaGuoZhi opened this issue May 3, 2022 · 1 comment · Fixed by #1026
Assignees
@SimplyLiz
Labels
bug Something isn't working core affects the core / engine
Milestone
Cytopia v0.4

Comments

@iaGuoZhi
Copy link
Member

iaGuoZhi commented May 3, 2022

Buildings are duplicated when I load the saved game.

image

image

Cytopia: 0.2.1
screenresolution: 1280:800
@SimplyLiz
Copy link
Contributor

I see, this is because I moved the render flags (deactivate rendering) from mapnode class to sprite class.
This will be addressed with my next pr when I’ll move settileid from map to mapnodes.

@SimplyLiz SimplyLiz self-assigned this May 3, 2022
@SimplyLiz SimplyLiz added bug Something isn't working core affects the core / engine labels May 3, 2022
@SimplyLiz SimplyLiz added this to the Cytopia v0.4 milestone May 3, 2022
@iaGuoZhi iaGuoZhi mentioned this issue Nov 25, 2022
Draft
4 tasks
iaGuoZhi added a commit to iaGuoZhi/Cytopia that referenced this issue Nov 29, 2022
@iaGuoZhi
fix: duplicate buildings when load saved game (CytopiaTeam#892)
b53998a
iaGuoZhi added a commit that referenced this issue Nov 29, 2022
@iaGuoZhi
fix: duplicate buildings when load saved game (#892)
4e5c39f
@iaGuoZhi iaGuoZhi mentioned this issue Nov 29, 2022
Merged
@lizzyd710 lizzyd710 linked a pull request Jan 15, 2023 that will close this issue
fix: duplicate buildings when load saved game (#892) #1026
Merged
lizzyd710 pushed a commit that referenced this issue Jan 15, 2023
@iaGuoZhi
fix: duplicate buildings when load saved game (#892) (#1026)
fdb1ae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimplyLiz SimplyLiz

Labels
bug Something isn't working core affects the core / engine
Projects
None yet
Milestone
Cytopia v0.4
Development

Successfully merging a pull request may close this issue.

fix: duplicate buildings when load saved game (#892) CytopiaTeam/Cytopia
2 participants
@SimplyLiz @iaGuoZhi