Skip to content

Add a CI that test against vibe-d:tls #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

Add a CI that test against vibe-d:tls #76

merged 1 commit into from
May 31, 2022

Conversation

Geod24
Copy link
Collaborator

@Geod24 Geod24 commented May 31, 2022

Because I'm lazy I don't want to have to do it myself every time :)

CyberShadow
CyberShadow approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CyberShadow
CyberShadow reviewed May 31, 2022
View reviewed changes
.github/workflows/ci.yml Outdated

- name: 'Test with Vibe.d'
run: |
if [ ! -f $GITHUB_WORKSPACE/openssl/dub.sdl ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the clone action sets GITHUB_WORKSPACE to the cloned repository.

@Geod24
Copy link
Collaborator Author

Geod24 commented May 31, 2022

Right I misread the documentation.

    # Relative path under $GITHUB_WORKSPACE to place the repository
    path: ''

I assumed that the repository name was appended automatically.

@Geod24
Copy link
Collaborator Author

Geod24 commented May 31, 2022

Fetching openssl 1.1.6+1.0.1g (getting selected version)...

:grumpy:

@Geod24
Copy link
Collaborator Author

Geod24 commented May 31, 2022 

Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/v0.9.5-beta.1*:refs/remotes/origin/v0.9.5-beta.1* +refs/tags/v0.9.5-beta.1*:refs/tags/v0.9.5-beta.1*
  /usr/lib/git-core/git-remote-https: /home/runner/work/openssl/openssl/openssl/install/lib/libcrypto.so.1.1: version `OPENSSL_1_1_1' not found (required by /lib/x86_64-linux-gnu/libssh.so.4)
  The process '/usr/bin/git' failed with exit code 128

Okay maybe removing OpenSSL from the system isn't that smart.

@Geod24 Geod24 force-pushed the vibed-ci branch 2 times, most recently from 13a8a3c to 1785696 Compare May 31, 2022 10:53
Geod24
Geod24 commented May 31, 2022
View reviewed changes
.github/workflows/ci.yml
with:
repository: 'vibe-d/vibe.d'
# Use a fixed ref to avoid random breakage due to upstream
# The first release compatible with this CI is v0.9.5-beta.2,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit compatible is actually f9f122e71e679ca41130330a66b589e643fe23be but I anticipated.

@Geod24 Geod24 force-pushed the vibed-ci branch 3 times, most recently from 4768c74 to dbcddb4 Compare May 31, 2022 11:21
@Geod24
Copy link
Collaborator Author

Geod24 commented May 31, 2022

Interesting that DMD works with 1.0.2 but not LDC 🤔

@Geod24
Copy link
Collaborator Author

Geod24 commented May 31, 2022

Ready to go. We just don't run the Vibe.d test for 1.0.2u

CyberShadow
CyberShadow reviewed May 31, 2022
View reviewed changes
Copy link
Member

@CyberShadow CyberShadow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing comes to mind. Vibe.d, being a big project, is probably more sensitive to changes in compilers than just the bindings. Since we're pinning the Vibe.d version (which makes sense to me), I think it would make sense to also pin the compiler versions, instead of dmd-latest and ldc-latest.

@Geod24
Copy link
Collaborator Author

Geod24 commented May 31, 2022

Applied suggestions

@CyberShadow CyberShadow merged commit c666ebd into D-Programming-Deimos:master May 31, 2022
@Geod24 Geod24 deleted the vibed-ci branch May 31, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberShadow CyberShadow CyberShadow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geod24 @CyberShadow