Add Native Token Staking Contract #655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello! thanks for the contribution. @mccallofthewild would you mind expanding on what you'd like to use this contract for? i am very happy to review, just curious so i can situate it. we also have a native token staking contract here: https://github.com/DA0-DA0/dao-contracts/tree/main/contracts/voting/dao-voting-native-staked, though it does not have staking hooks so i could see why this would be preferable. have you seen that one? i'd be interested in your thoughts on if that's worth improving, or if we should replace it with this. to fix the lint issue: to fix the typescript generation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop-in
sdk.Coinsstaking contract compatible with cw20-stake. All tests passing. This seems like a cleaner approach than merging the proposal and staking modules.This makes progress on syncing DAO DAO with the protocol level as referenced in #543. Easiest way to do this while accounting for slashing is by nesting validator staking contracts under a root staking contract.
I also have something that automatically provisions staking reward distributors for any token. At the protocol level it would make airdrops extremely simple.