-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-propose-approval support for multiple choice proposals, and freeze approver #883
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #883 +/- ##
===============================================
- Coverage 96.67% 96.65% -0.03%
===============================================
Files 241 245 +4
Lines 65993 67224 +1231
===============================================
+ Hits 63802 64974 +1172
- Misses 2191 2250 +59 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, I don't have much to add.
maybe except that the dao_pre_propose_base
design combined with message extensions is super clean and holding up really well!
contracts/pre-propose/dao-pre-propose-approval-single/src/contract.rs
Outdated
Show resolved
Hide resolved
91d5e8b
to
96b3aff
Compare
this does two things:
it creates a dao-pre-propose-approval-multiple contract so that multiple choice proposal modules can have approvers, just like single choice proposal modules. it also ensures the approver contract works for both approval-single and approval-multiple
it freezes the
approver
in the proposal so that a previously created pending proposal does not change approvers if the approver gets updated while it's still pending. this maintains consistency with other DAO logic to keep things intuitive, where the members who can vote on a proposal are frozen upon proposal creation.