Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils package #438

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Utils package #438

merged 4 commits into from
Mar 25, 2022

Conversation

sagarsaija
Copy link
Contributor

Issue: #387

This is a first pass at moving the isValidAddress function into a utils package. The util functions in formValidation.ts will be moved in the next pass along with the rest of the util functions.

@vercel
Copy link

vercel bot commented Mar 21, 2022

@sagarsaija is attempting to deploy a commit to the DAO DAO Team on Vercel.

To accomplish this, @sagarsaija needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@sagarsaija sagarsaija changed the title Add utils package Utils package Mar 21, 2022
Copy link
Member

@NoahSaso NoahSaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Think we should set the package version number, but it looks great otherwise :)

Copy link
Contributor

@ebaker ebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @sagarsaija 🥇

lgtm 🚢

Co-authored-by: Noah Saso <noahsaso@gmail.com>
@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/da0da0/dao-dao/H6Ys3FN8bsqPmUALNmH3F1Zhvwms
✅ Preview: Failed

@JakeHartnell JakeHartnell merged commit 8046549 into development Mar 25, 2022
@JakeHartnell JakeHartnell deleted the util-package branch March 25, 2022 18:24
@NoahSaso NoahSaso mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants