Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds guard for persisters returning bad state #147

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Apr 8, 2024

The entire call from load_state should be None if something isn't found.

Otherwise the persister should fix its assumptions/make sure None state is not saved.

Changes

  • ApplicationBuilder code
  • test for it

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

The entire call from load_state should be None if something
isn't found.

Otherwise the persister should fix its assumptions/make sure None
state is not saved.
@skrawcz skrawcz mentioned this pull request Apr 8, 2024
7 tasks
Copy link
Contributor

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@skrawcz skrawcz merged commit 8b66190 into main Apr 8, 2024
7 checks passed
@skrawcz skrawcz deleted the add_none_guard_persister_load_from branch April 8, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants