Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parallelism example #431

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update parallelism example #431

merged 3 commits into from
Nov 21, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Nov 21, 2024

Updates parallelism example + some minor typo fixes in docs.

Changes

  • changes doc strings
  • parallelism example notebook

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

They had syntax errors.
Updates to be more comprehensive and show more.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 76cb63a in 12 seconds

More details
  • Looked at 102 lines of code in 3 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. burr/core/parallelism.py:335
  • Draft comment:
    Consider using list[str] instead of List[str] for consistency with other parts of the file. This change is applicable in other parts of the file as well, such as lines 451 and 455.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from List[str] to list[str] is consistent with Python 3.9+ type hinting standards. However, the change is not applied consistently across the file.

Workflow ID: wflow_WMUk4zlSQoJD1tXh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Nov 21, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/431

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/431/

@skrawcz skrawcz merged commit 329e613 into main Nov 21, 2024
11 checks passed
@skrawcz skrawcz deleted the update_parallelism_example branch November 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant