Added Github Actions support #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahjsmith
reviewed
May 19, 2020
|
Yep, just updated the README, it's mostly just "skip this step if you're using github actions instead of travis", there's one thing about PyPI API tokens but that's it. |
For sure, maybe just a quick discussion to how someone would properly set the github secret for this token (linking to https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) perhaps |
micahjsmith
approved these changes
May 19, 2020
There was a problem hiding this comment.
lgtm, please get a review from @csala as well before merging
csala
suggested changes
May 19, 2020
csala
approved these changes
May 20, 2020
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@csala @micahjsmith This draft pull request adds support for Github Actions. Here's an example repository which shows the result of running this cookiecutter with the default options (Github Actions is now the default CI provider).