Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect phase seeking in vt data reader #573

Closed
ppebay opened this issue Dec 20, 2024 · 0 comments · Fixed by #580
Closed

Fix incorrect phase seeking in vt data reader #573

ppebay opened this issue Dec 20, 2024 · 0 comments · Fixed by #580
Assignees
Labels
bug Something isn't working

Comments

@ppebay
Copy link
Contributor

ppebay commented Dec 20, 2024

In the definition of _populate_rank(), the following block:

# Seek phase with given ID
        phase_id_found = False
        for phase in self.__vt_data.get(rank_id).get("phases"):
            if (curr_phase_id := phase["id"]) != phase_id:
                # Ignore phases that are not of interest
                self.__logger.debug(
                    f"Ignored phase {curr_phase_id} for rank {rank_id}")
                continue
            # Desired phase was found
            phase_id_found = True
            break

will result in an incorrect phase if the ID was not found.

This must be protected by a final test on phase_id_found and result in an error (and exit) if not found.

@ppebay ppebay added the bug Something isn't working label Dec 20, 2024
ppebay added a commit that referenced this issue Dec 26, 2024
ppebay added a commit that referenced this issue Dec 26, 2024
ppebay added a commit that referenced this issue Dec 26, 2024
…nges (#580)

* #573: verified that no bug is actually present but made stylistic changes nonetheless

* #573: whitespace cleanup
github-actions bot pushed a commit that referenced this issue Dec 26, 2024
…nges (#580)

* #573: verified that no bug is actually present but made stylistic changes nonetheless

* #573: whitespace cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants