#475: Investigate failing PyPi package (v1.0.1) #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwschilly
force-pushed
the
475-investigate-failing-pypi-package-v101
branch
from
b7b714e to
a882e56
Compare
|
The CI failure is unrelated to this PR; it is fixed by PR #478 |
cwschilly
force-pushed
the
475-investigate-failing-pypi-package-v101
branch
from
a882e56 to
4ae9406
Compare
ppebay
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475
The issue was the use of absolute file paths; since the package directory structure is slightly different from the source code (no
srcdir), we should use relative paths whenever possible.I also changed
overwriteto False when lbaf is installed as a package, as discussed in the meeting.