Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#562: output: add output to JSON for vt-tv for derived stats #563

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

lifflander
Copy link
Contributor

@lifflander lifflander commented Dec 5, 2024

@lifflander lifflander linked an issue Dec 5, 2024 that may be closed by this pull request
@ppebay ppebay changed the title #558: output: add output to JSON for vt-tv for dervied stats #558: output: add output to JSON for vt-tv for derived stats Dec 14, 2024
@ppebay ppebay assigned ppebay and cwschilly and unassigned ppebay Dec 17, 2024
@ppebay
Copy link
Contributor

ppebay commented Dec 17, 2024

Assigning @cwschilly to resolve conflicts due to recent merges

@cwschilly cwschilly force-pushed the 562-add-dervied-stats-to-output-for-vt-tv branch from edb69a6 to 845315d Compare December 17, 2024 16:08
@cwschilly cwschilly changed the title #558: output: add output to JSON for vt-tv for derived stats #562: output: add output to JSON for vt-tv for derived stats Dec 18, 2024
@ppebay
Copy link
Contributor

ppebay commented Dec 19, 2024

@cwschilly the merger of PR #570 has resulted in conflicts in this PR, can you please also look into those? Thanks!

@cwschilly cwschilly force-pushed the 562-add-dervied-stats-to-output-for-vt-tv branch from cb24d13 to 9fdfe7a Compare December 19, 2024 17:37
@cwschilly cwschilly marked this pull request as ready for review December 19, 2024 20:31
@cwschilly cwschilly requested a review from ppebay December 19, 2024 20:32
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf. comments

src/lbaf/Model/lbsBlock.py Outdated Show resolved Hide resolved
src/lbaf/Model/lbsObject.py Outdated Show resolved Hide resolved
src/lbaf/Model/lbsObject.py Show resolved Hide resolved
src/lbaf/Model/lbsObject.py Outdated Show resolved Hide resolved
@cwschilly cwschilly requested a review from ppebay December 20, 2024 18:16
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for corrections @cwschilly

Copy link
Contributor Author

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ppebay ppebay merged commit 23fff49 into develop Dec 23, 2024
11 checks passed
@ppebay ppebay deleted the 562-add-dervied-stats-to-output-for-vt-tv branch December 23, 2024 17:53
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
* #558: output: add output to JSON for vt-tv for dervied stats

* #562: iterate through rank qoi; make get_QOIs return pre-processed name

* #562: fix failing test

* #562: writer: use object qoi getter instead of hard-coded qois

* #562: add decorator for entity properties

* #562: fix pylint warnings; clean up obj qoi getter

* #562: clarify name of obj qoi getter function

---------

Co-authored-by: Caleb Schilly <cwschilly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add derived stats to output for vt-tv
3 participants