-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#562: output: add output to JSON for vt-tv for derived stats #563
Conversation
Assigning @cwschilly to resolve conflicts due to recent merges |
edb69a6
to
845315d
Compare
@cwschilly the merger of PR #570 has resulted in conflicts in this PR, can you please also look into those? Thanks! |
cb24d13
to
9fdfe7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cf. comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for corrections @cwschilly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
* #558: output: add output to JSON for vt-tv for dervied stats * #562: iterate through rank qoi; make get_QOIs return pre-processed name * #562: fix failing test * #562: writer: use object qoi getter instead of hard-coded qois * #562: add decorator for entity properties * #562: fix pylint warnings; clean up obj qoi getter * #562: clarify name of obj qoi getter function --------- Co-authored-by: Caleb Schilly <cwschilly@gmail.com>
Fixes #562
Linked to: