#123 fix code review issues

- do not size underlying 'struct FILE' when footprinting FILE* pointer
- simplify queue serialization to avoid copying
- fix grammar typo

src/checkpoint/container/queue_serialize.h

@@ -52,51 +52,28 @@
 namespace checkpoint {
 
 template <typename Serializer, typename T>
-void serialize(Serializer& s, std::queue<T> q) {
+void serialize(Serializer& s, const std::queue<T>& q) {
   serializeQueue(s, q);
 }
 
-template <
-  typename SerializerT,
-  typename T,
-  typename = std::enable_if_t<
-    std::is_same<
-      SerializerT,
-      checkpoint::Footprinter
-    >::value
-  >
->
-void serializeQueue(SerializerT& s, std::queue<T> q) {
-  s.countBytes(q);
-  while (not q.empty())
-  {
-    s | q.front();
-    q.pop();
-  }
-}
-
 template <typename Serializer, typename T>
-void serialize(Serializer& s, std::priority_queue<T> q) {
+void serialize(Serializer& s, const std::priority_queue<T>& q) {
   serializeQueue(s, q);
 }
 
 template <
   typename SerializerT,
-  typename T,
+  typename Q,
   typename = std::enable_if_t<
     std::is_same<
       SerializerT,
       checkpoint::Footprinter
     >::value
   >
 >
-void serializeQueue(SerializerT& s, std::priority_queue<T> q) {
+void serializeQueue(SerializerT& s, const Q& q) {
   s.countBytes(q);
-  while (not q.empty())
-  {
-    s | q.top();
-    q.pop();
-  }
+  s.contiguousBytes(nullptr, sizeof(typename Q::value_type), q.size());
 }
 
 } /* end namespace checkpoint */

src/checkpoint/container/raw_ptr_serialize.h

@@ -83,8 +83,8 @@ void serializeRawPtr(SerializerT& s, T* ptr) {
 /**
  * \brief Serialize FILE pointer \c ptr
  *
- * Only footprinting mode is supported at the moment. Counts the pointer and
- * pointee (underlying struct) size without following it.
+ * Only footprinting mode is supported at the moment. Counts the pointer size
+ * without following it.
  *
  * \param[in] serializer serializer to use
  * \param[in] ptr pointer to serialize
@@ -106,9 +106,6 @@ template <
 >
 void serializeFilePtr(SerializerT& s, FILE* ptr) {
   s.countBytes(ptr);
-  if (ptr != nullptr) {
-    s.countBytes(*ptr);
-  }
 }
 
 } /* end namespace checkpoint */

src/checkpoint/container/string_serialize.h

@@ -61,7 +61,7 @@ void serializeStringMeta(Serializer& s, std::string& str) {
 /**
  * \brief Serialize string \c str
  *
- * Resizes a string to it's actual size and serializes it.
+ * Resizes a string to its actual size and serializes it.
  * Note: footprinting mode does not detect small string optimization, so
  * a limited overcount is possible.
  *