#156: footprinting: use dispatch::serializeArray

DARMA-tasking · Nov 21, 2020 · e91b3dd · e91b3dd
1 parent 327947e
commit e91b3dd
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 14 deletions.
diff --git a/src/checkpoint/container/vector_serialize.h b/src/checkpoint/container/vector_serialize.h
@@ -102,20 +102,6 @@ void serialize(Serializer& s, std::vector<bool, VectorAllocator>& vec) {
   }
 }
 
-template <
-  typename SerializerT,
-  typename T,
-  typename VectorAllocator,
-  typename = std::enable_if_t<
-    not SerializableTraits<T, SerializerT>::has_serialize_function and
-    not SerializableTraits<T, SerializerT>::is_bytecopyable
-  >
->
-void serialize(SerializerT& s, std::vector<T, VectorAllocator>& vec) {
-  s.countBytes(vec);
-  s.addBytes(vec.capacity() * sizeof(T));
-}
-
 } /* end namespace checkpoint */
 
 #endif /*INCLUDED_CHECKPOINT_CONTAINER_VECTOR_SERIALIZE_H*/
diff --git a/src/checkpoint/dispatch/dispatch.impl.h b/src/checkpoint/dispatch/dispatch.impl.h
@@ -127,6 +127,17 @@ inline void serializeArray(Serializer& s, T* array, SerialSizeType const len) {
   }
 }
 
+template <
+  typename Serializer,
+  typename T,
+  typename = std::enable_if_t<
+    not SerializableTraits<T>::is_footprintable_v
+  >
+>
+inline void serializeArray(Serializer& s, T* array, SerialSizeType const len) {
+  // count bytes
+}
+
 template <typename T>
 buffer::ImplReturnType packBuffer(
   T& target, SerialSizeType size, BufferObtainFnType fn

diff --git a/src/checkpoint/traits/serializable_traits.h b/src/checkpoint/traits/serializable_traits.h
@@ -210,6 +210,14 @@ struct SerializableTraits {
    */
   static constexpr auto const is_serializable =
     has_serialize_function and is_constructible;
+
+  using is_footprintable = std::is_same<
+    std::size_t,
+    decltype(checkpoint::getMemoryFootprint(std::declval<T&>()))
+  >;
+
+  static constexpr auto const is_footprintable_v =
+    is_footprintable::value;
 };
 
 }  // end namespace checkpoint

diff --git a/tests/unit/test_footprinter.cc b/tests/unit/test_footprinter.cc
@@ -49,6 +49,7 @@
 #include <atomic>
 #include <thread>
 #include <checkpoint/checkpoint.h>
+#include <checkpoint/traits/serializable_traits.h>
 
 struct ompi_communicator_t;
 struct ompi_group_t;
@@ -600,6 +601,12 @@ struct TestNoSerialize {
 TEST_F(TestFootprinter, test_no_serialize) {
   std::vector<TestNoSerialize> v(7);
 
+  std::cout << std::boolalpha;
+  std::cout << SerializableTraits<int>::is_footprintable_v << std::endl;
+  std::cout << SerializableTraits<Test1>::is_footprintable_v << std::endl;
+  std::cout << SerializableTraits<TestNoSerialize>::is_footprintable_v << std::endl;
+  // all 3 return 'true'
+
   EXPECT_EQ(
     checkpoint::getMemoryFootprint(v),
     sizeof(v) + v.capacity() * sizeof(TestNoSerialize)