Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GTest imported targets #303

Closed
nmm0 opened this issue May 8, 2023 · 0 comments · Fixed by #304
Closed

Use GTest imported targets #303

nmm0 opened this issue May 8, 2023 · 0 comments · Fixed by #304
Assignees
@nmm0
Labels
enhancement New feature or request

Comments

@nmm0
Copy link
Contributor

nmm0 commented May 8, 2023

Imported targets should be preferred here since it can catch errors at configure time vs compile time.
@nmm0 nmm0 added the enhancement New feature or request label May 8, 2023
@nmm0 nmm0 self-assigned this May 8, 2023
nmm0 added a commit that referenced this issue May 9, 2023
@nmm0
#303: cmake: use GTest::gtest and GTest::gtest_main imported targets
471744c
This was referenced May 9, 2023
Merged
Open
nmm0 added a commit that referenced this issue Jun 1, 2023
@nmm0
#303: cmake: use GTest::gtest and GTest::gtest_main imported targets
6d00dcd
nmm0 added a commit that referenced this issue Jun 5, 2023
@nmm0
#303: cmake: remove defintion for GTEST_BOTH_LIBRARIES
e4af46d
nlslatt added a commit that referenced this issue Jun 6, 2023
@nlslatt
Merge pull request #304 from DARMA-tasking/303-use-gtest-imported-tar…
87f1ab4 
…gets

#303: use gtest imported targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmm0 nmm0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#303: use gtest imported targets DARMA-tasking/magistrate
1 participant
@nmm0