Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more warnings and then eliminate their sources #333

Closed
nlslatt opened this issue Apr 8, 2024 · 0 comments · Fixed by #334
Closed

Add more warnings and then eliminate their sources #333

nlslatt opened this issue Apr 8, 2024 · 0 comments · Fixed by #334

Comments

@nlslatt
Copy link
Contributor

nlslatt commented Apr 8, 2024

Add this patch to magistrate and then clean up the sources of new warnings:

diff --git a/cmake/turn_on_warnings.cmake b/cmake/turn_on_warnings.cmake
index f492db2..5527255 100644
--- a/cmake/turn_on_warnings.cmake
+++ b/cmake/turn_on_warnings.cmake
@@ -14,6 +14,10 @@ endfunction()
 get_directory_property(hasParent PARENT_DIRECTORY)
 if(NOT hasParent)
   enable_cxx_compiler_flag_if_supported("-Wall")
+  enable_cxx_compiler_flag_if_supported("-Wextra")
+  enable_cxx_compiler_flag_if_supported("-Wshadow")
+  enable_cxx_compiler_flag_if_supported("-Wnon-virtual-dtor")
+  enable_cxx_compiler_flag_if_supported("-Wsuggest-override")
   enable_cxx_compiler_flag_if_supported("-pedantic")
   enable_cxx_compiler_flag_if_supported("-Wno-unknown-pragmas")
 endif()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant