-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#132: Virtual Serialization: Spare need for self-class type macro arguments #133
Conversation
Handling for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We could do this in two steps starting with this to remove one of the parameters. We will need to time this with an update to EMPIRE when we merge this.
Both modified macros are under new names, with the old names that take the existing arguments kept for backwards compatibility. So, we can merge into EMPIRE whenever, update it at leisure, and then drop out the old ones. |
Also, I went looking and saw that until vt#1013, nothing there uses the virtual serialization machinery at all. |
So, if we adopt this sooner rather than later, footprinting code can just use the new form from day one. Anyway, given you're happy with this, I'll do the clean-up on formatting and whatnot, and we can merge this. |
No description provided.