Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

143 fix virtual serialization with abstract classes in hierarchy #144

Merged
merged 7 commits into from
Oct 19, 2020
Merged

143 fix virtual serialization with abstract classes in hierarchy #144

merged 7 commits into from
Oct 19, 2020

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Oct 19, 2020

Fixes #143

@cz4rs cz4rs mentioned this pull request Oct 19, 2020
Closed
@lifflander
Copy link
Contributor

lifflander commented Oct 19, 2020 •
edited
Loading

I just pushed the fix. I used too strong a trait when I refactored for #127 for specialized serializers.

This was stopping registration of classes that are not concrete because they aren't constructible by definition.

@lifflander lifflander marked this pull request as ready for review October 19, 2020 20:31
PhilMiller
PhilMiller approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the failure I was encountering in EMPIRE

@cz4rs
Copy link
Contributor Author

cz4rs commented Oct 19, 2020

I've just confirmed that this fixes the issue that I was facing in vt as well 👍

@PhilMiller
Copy link
Member

Modified/moved test code is broken due to missing constructors entirely

@lifflander
Copy link
Contributor

Modified/moved test code is broken due to missing constructors entirely

Yes, I just fixed it. Copy-paste error

@lifflander lifflander merged commit a91a0a3 into develop Oct 19, 2020
@cz4rs cz4rs changed the title 143 fix virtual serialization of templated classes 143 fix virtual serialization with abstract classes in hierarchy Oct 19, 2020
@lifflander lifflander mentioned this pull request Oct 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@lifflander lifflander Awaiting requested review from lifflander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cz4rs @lifflander @PhilMiller