247 dynrankview fails to serialize when rank is 0 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks wrong. A rank 0 view has a single scalar value |
nlslatt
requested changes
Jun 15, 2022
There was a problem hiding this comment.
From a brief discussion with @rppawlo, it sounds like an uninitialized DynRankView will have dim 0 and size 0, while a single scalar DynRankView will have dim 0 and non-zero size. This PR, including tests, should be updated to reflect that.
nlslatt
approved these changes
Jun 16, 2022
PhilMiller
reviewed
Jun 28, 2022
PhilMiller
reviewed
Jun 28, 2022
PhilMiller
reviewed
Jun 28, 2022
PhilMiller
reviewed
Jun 28, 2022
PhilMiller
force-pushed
the
247-dynrankview-fails-to-serialize-when-rank-is-0
branch
from
888069e to
10d099c
Compare
PhilMiller
approved these changes
Jul 15, 2022
PhilMiller
force-pushed
the
247-dynrankview-fails-to-serialize-when-rank-is-0
branch
from
10d099c to
c0891ab
Compare
PhilMiller
force-pushed
the
247-dynrankview-fails-to-serialize-when-rank-is-0
branch
from
c0891ab to
c9d6f9f
Compare
PhilMiller
reviewed
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247