Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#308: Rename KOKKOS macros #340

Merged
merged 2 commits into from
Jun 21, 2024
Merged

#308: Rename KOKKOS macros #340

merged 2 commits into from
Jun 21, 2024

Conversation

thearusable
Copy link
Contributor

Closes #308

@thearusable thearusable self-assigned this May 22, 2024
cz4rs
cz4rs reviewed May 22, 2024
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
cz4rs
cz4rs approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PhilMiller
Copy link
Member

Make sure that application code wasn't relying on any of these macros, or that it gets updated with any shift to a newer version of Magistrate

lifflander
lifflander approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that apps are depending on this macro.

@thearusable thearusable force-pushed the 308-rename-kokkos-macros branch from 3c4ffff to 5e4b793 Compare May 28, 2024 16:39
@thearusable thearusable force-pushed the 308-rename-kokkos-macros branch 3 times, most recently from 1ae7b82 to e106736 Compare June 12, 2024 15:06
@thearusable thearusable force-pushed the 308-rename-kokkos-macros branch from e106736 to 6afd9b4 Compare June 18, 2024 16:38
@thearusable thearusable force-pushed the 308-rename-kokkos-macros branch from 6afd9b4 to 0fb01b2 Compare June 21, 2024 13:40
@nlslatt nlslatt merged commit 33a4dce into develop Jun 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename macros prefixed with KOKKOS_
6 participants
@thearusable @PhilMiller @lifflander @cz4rs @JacobDomagala @nlslatt