Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#350: Prefix CMake internal variables with magistrate_ and create a new target named magistrate to enable the use of find_package(magistrate) #353

Merged
merged 8 commits into from
Jul 8, 2024
Merged

#350: Prefix CMake internal variables with magistrate_ and create a new target named magistrate to enable the use of find_package(magistrate) #353

merged 8 commits into from
Jul 8, 2024

Conversation

JacobDomagala
Copy link
Contributor

@JacobDomagala JacobDomagala commented Jun 19, 2024 •
edited
Loading

Fixes #350

TODO:

  • options should be prefixed with magistrate
  • CMake should generate magistrate files so it's possible to use find_package(magistrate)

@JacobDomagala JacobDomagala self-assigned this Jun 19, 2024
@JacobDomagala JacobDomagala linked an issue Jun 19, 2024 that may be closed by this pull request
CMake build variables should be aliased to magistrate #350
Closed
@JacobDomagala JacobDomagala changed the title #350: Add deprecated_option CMake function that warns the user about deprecated options #350: Add deprecated_option CMake function that warns user about deprecated options Jun 19, 2024
@JacobDomagala JacobDomagala changed the title #350: Add deprecated_option CMake function that warns user about deprecated options #350: Change CMake internals to magistrate Jun 19, 2024
@JacobDomagala JacobDomagala force-pushed the 350-cmake-build-variables-should-be-aliased-to-magistrate branch 3 times, most recently from cd627af to 8aed00e Compare June 20, 2024 14:13
@JacobDomagala JacobDomagala changed the title #350: Change CMake internals to magistrate #350: Prefix CMake internal variables with magistrate_ and create a new target named magistrate to enable the use of find_package(magistrate) Jun 20, 2024
@JacobDomagala JacobDomagala force-pushed the 350-cmake-build-variables-should-be-aliased-to-magistrate branch 3 times, most recently from e102d59 to 5a55269 Compare June 24, 2024 19:44
@JacobDomagala JacobDomagala marked this pull request as ready for review June 25, 2024 12:23
cz4rs
cz4rs reviewed Jun 25, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@JacobDomagala JacobDomagala mentioned this pull request Jun 26, 2024
Closed
@JacobDomagala
Copy link
Contributor Author

Created DARMA-tasking/vt#2310 that uses this branch to build vt (with find_package(magistrate) and vt::lib::magistrate as CMake target)

cz4rs
cz4rs approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JacobDomagala JacobDomagala force-pushed the 350-cmake-build-variables-should-be-aliased-to-magistrate branch from a064398 to a3e095c Compare July 3, 2024 21:30
@JacobDomagala JacobDomagala force-pushed the 350-cmake-build-variables-should-be-aliased-to-magistrate branch from 6384d52 to 2c9ed35 Compare July 3, 2024 21:53
lifflander
lifflander approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lifflander lifflander merged commit f75c80c into develop Jul 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

@nmm0 nmm0 Awaiting requested review from nmm0

@thearusable thearusable Awaiting requested review from thearusable

Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake build variables should be aliased to magistrate
3 participants
@JacobDomagala @lifflander @cz4rs