Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#354: Bump minimum CMake version to 3.23 and update find_package_local to work with packageName_ROOT #355

Merged

Conversation

JacobDomagala
Copy link
Contributor

Fixes #354

@JacobDomagala JacobDomagala self-assigned this Jun 24, 2024
@JacobDomagala JacobDomagala linked an issue Jun 24, 2024 that may be closed by this pull request
@JacobDomagala JacobDomagala marked this pull request as draft June 24, 2024 11:59
@JacobDomagala JacobDomagala force-pushed the 354-bump-cmake_minimum_required-to-323-to-match-vt branch from d251958 to 3815ada Compare June 24, 2024 12:32
@JacobDomagala JacobDomagala marked this pull request as ready for review June 24, 2024 13:11
cmake/load_package.cmake Outdated Show resolved Hide resolved
cmake/load_package.cmake Outdated Show resolved Hide resolved
@JacobDomagala JacobDomagala force-pushed the 354-bump-cmake_minimum_required-to-323-to-match-vt branch from 61e15e7 to bc9a21b Compare June 26, 2024 10:48
@JacobDomagala JacobDomagala requested a review from nmm0 June 26, 2024 11:14
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lifflander lifflander merged commit 78f27b4 into develop Jul 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump cmake_minimum_required to 3.23 to match vt
4 participants