Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#356: Fix backward compatibility with using magistrate via add_subdirectory() and wanting to use vt::lib::checkpoint target #357

Merged
merged 1 commit into from
Jul 9, 2024
Merged

#356: Fix backward compatibility with using magistrate via add_subdirectory() and wanting to use vt::lib::checkpoint target #357

merged 1 commit into from
Jul 9, 2024

Conversation

JacobDomagala
Copy link
Contributor

@JacobDomagala JacobDomagala commented Jul 9, 2024 •
edited
Loading

Fixes #356

When using magistrate via find_package(magistrate) following targets are visible:

  • vt::lib::checkpoint (main exported target)
  • vt::lib::magistrate (an alias created in magistrateConfig.cmake file)

When using magistrate via find_package(checkpoint) following targets are visible:

  • vt::lib::checkpoint (main exported target)

When using magistrate via add_subdirectory(checkpoint) following targets are visible:

  • magistrate (main target)
  • vt::lib::magistrate (alias)
  • vt::lib::checkpoint (alias)

@JacobDomagala
#356: Fix backward compatibility with using magistrate via add_subdir…
81e5a79 
…ectory() and wanting to use vt::lib::checkpoint target
@JacobDomagala JacobDomagala self-assigned this Jul 9, 2024
@JacobDomagala JacobDomagala marked this pull request as ready for review July 9, 2024 16:28
@lifflander lifflander merged commit 9ddefa7 into develop Jul 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@cz4rs cz4rs Awaiting requested review from cz4rs

@nmm0 nmm0 Awaiting requested review from nmm0

@thearusable thearusable Awaiting requested review from thearusable

Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate the failing vt-sample builds that use magistrate as TPL
2 participants
@JacobDomagala @lifflander