Skip to content

Commit

Permalink
#97: try fix mesa on ubuntu 24
Browse files Browse the repository at this point in the history
  • Loading branch information
tlamonthezie committed Sep 5, 2024
1 parent 050a3b1 commit 2365fdb
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
24 changes: 24 additions & 0 deletions .github/workflows/build-and-test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ jobs:
libglu1-mesa-dev \
mesa-common-dev \
libosmesa6-dev \
mesa-utils \
perl \
curl \
xvfb \
Expand All @@ -123,6 +124,29 @@ jobs:
sudo apt-get clean && \
sudo rm -rf /var/lib/apt/lists/*
- name: Install Latest Mesa Drivers (Ubuntu 24.04)
if: ${{matrix.host.base == 'ubuntu-24.04'}}
run: |
# Start virtual display (Linux)
DISPLAY_0=$(echo $DISPLAY)
if [[ $(uname -a) != *"Darwin"* ]]; then
bash ci/xvfb_start.sh :99
export DISPLAY=:99
fi
glxinfo | grep "OpenGL version"
sudo add-apt-repository ppa:oibaf/graphics-drivers -y
sudo apt update
sudo apt upgrade
glxinfo | grep "OpenGL version"
# Restore display (none)
if [[ $(uname -a) != *"Darwin"* ]]; then
bash ci/xvfb_stop.sh :99
export DISPLAY=DISPLAY_0
fi
- name: Load cache (VTK, Miniconda3)
id: base-cache
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/tv.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void tvFromJson(const std::vector<std::string>& input_json_per_rank_list, const

// Throw an error if the output directory does not exist or is not absolute
if (!std::filesystem::exists(output_path)) {
throw std::runtime_error("Visualization output directory does not exist.");
throw std::runtime_error(fmt::format("Visualization output directory does not exist at {}", output_dir));
}
if (!output_path.is_absolute()) {
throw std::runtime_error("Visualization output directory must be absolute.");
Expand Down

0 comments on commit 2365fdb

Please sign in to comment.