Skip to content

Commit

Permalink
Merge pull request #2113 from DARMA-tasking/2111-silence-nvcc-warnings
Browse files Browse the repository at this point in the history
#2111: Silence `nvcc` warnings
  • Loading branch information
PhilMiller authored Mar 26, 2023
2 parents e87e1b0 + b5e5348 commit 9eeb7f0
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/vt/objgroup/proxy/proxy_objgroup.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ Proxy<ObjT>::broadcast(Params&&... params) const {
auto msg = makeMessage<MsgT>(std::forward<Params>(params)...);
return broadcastMsg<MsgT, f>(msg);
}

// Silence nvcc warning (no longer needed for CUDA 11.7 and up)
return typename Proxy<ObjT>::PendingSendType{std::nullptr_t{}};
}

template <typename ObjT>
Expand Down
3 changes: 3 additions & 0 deletions src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ ProxyElm<ObjT>::send(Params&&... params) const {
auto msg = makeMessage<MsgT>(std::forward<Params>(params)...);
return sendMsg<MsgT, f>(msg);
}

// Silence nvcc warning (no longer needed for CUDA 11.7 and up)
return ProxyElm<ObjT>::PendingSendType{std::nullptr_t{}};
}

template <typename ObjT>
Expand Down
6 changes: 6 additions & 0 deletions src/vt/vrt/collection/broadcast/broadcastable.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ Broadcastable<ColT, IndexT, BaseProxyT>::broadcast(Params&&... params) const {
auto msg = makeMessage<MsgT>(std::forward<Params>(params)...);
return broadcastMsg<MsgT, f>(msg);
}

// Silence nvcc warning (no longer needed for CUDA 11.7 and up)
return messaging::PendingSend{std::nullptr_t{}};
}

template <typename ColT, typename IndexT, typename BaseProxyT>
Expand All @@ -220,6 +223,9 @@ Broadcastable<ColT, IndexT, BaseProxyT>::broadcastCollective(Params&&... params)
auto msg = makeMessage<MsgT>(std::forward<Params>(params)...);
return broadcastCollectiveMsg<MsgT, f>(msg);
}

// Silence nvcc warning (no longer needed for CUDA 11.7 and up)
return messaging::PendingSend{std::nullptr_t{}};
}

template <typename ColT, typename IndexT, typename BaseProxyT>
Expand Down
3 changes: 3 additions & 0 deletions src/vt/vrt/collection/send/sendable.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ messaging::PendingSend Sendable<ColT,IndexT,BaseProxyT>::send(Params&&... params
auto msg = makeMessage<MsgT>(std::forward<Params>(params)...);
return sendMsg<MsgT, f>(msg);
}

// Silence nvcc warning (no longer needed for CUDA 11.7 and up)
return messaging::PendingSend{std::nullptr_t{}};
}


Expand Down

0 comments on commit 9eeb7f0

Please sign in to comment.