Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NodeStats LB stat file output #1014

Closed
lifflander opened this issue Sep 1, 2020 · 3 comments · Fixed by #1029
Closed

Fix NodeStats LB stat file output #1014

lifflander opened this issue Sep 1, 2020 · 3 comments · Fixed by #1029
Assignees
@jstrzebonski
Labels
1.0.2 type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

Currently, after trimming NodeStats the LB mapping/stats file is no longer being output correctly.
@lifflander
Copy link
Collaborator Author

@jstrzebonski Please work on this next!

With #995 merged, we are trimming the data that is stored in NodeStats every phase based on how much past data is required but the models. However, the stat file output currently works by outputting at the very end. Now that it is being trimming, the LB stat file output will not output all the phases because they have been deleted from the NodeStats history. Thus, when stat file output is enabled, we need to incrementally write the stats for each phase to the stat file on each node.

See this part of the manual for an explanation of how stat file are exported.

@jstrzebonski
Copy link
Contributor

jstrzebonski commented Sep 4, 2020 •
edited
Loading

I moved my comment to the PR.

jstrzebonski pushed a commit that referenced this issue Sep 8, 2020
#1014 dump node stats before trimming
01e8a7f
@jstrzebonski jstrzebonski linked a pull request Sep 8, 2020 that will close this issue
#1014: dump node stats before trimming #1029
Merged
@jstrzebonski jstrzebonski mentioned this issue Sep 8, 2020
Merged
jstrzebonski pushed a commit that referenced this issue Sep 8, 2020
#1014 dump node stats before trimming
9e5ce14
@lifflander lifflander mentioned this issue Sep 8, 2020
Open
jstrzebonski pushed a commit that referenced this issue Sep 8, 2020
#1014 dump node stats before trimming
73d8726
jstrzebonski pushed a commit that referenced this issue Sep 10, 2020
#1014 dump node stats before trimming
1703aec
jstrzebonski pushed a commit that referenced this issue Sep 10, 2020
#1014 revert pointless changes (squash this before merge)
f4205a9
jstrzebonski pushed a commit that referenced this issue Sep 10, 2020
#1014 revert pointless changes (squash this before merge)
26afaea
jstrzebonski pushed a commit that referenced this issue Sep 10, 2020
#1014 revert pointless changes (squash this before merge)
4371ab7
jstrzebonski pushed a commit that referenced this issue Sep 17, 2020
#1014 dump node stats before trimming
dd3a766
jstrzebonski pushed a commit that referenced this issue Sep 17, 2020
#1014 revert pointless changes (squash this before merge)
1cbbd80
jstrzebonski pushed a commit that referenced this issue Sep 17, 2020
#1014 dump node stats before trimming
d1db882
jstrzebonski pushed a commit that referenced this issue Sep 17, 2020
#1014 review remarks (squash before merge)
6315e72
lifflander pushed a commit that referenced this issue Sep 18, 2020
@lifflander
#1014 dump node stats before trimming
354e94c
lifflander pushed a commit that referenced this issue Sep 18, 2020
@lifflander
#1014 review remarks (squash before merge)
6f78475
lifflander added a commit that referenced this issue Sep 18, 2020
@lifflander
#1014: runtime: check MPI_Comm for use during component startup
90901af
lifflander pushed a commit that referenced this issue Sep 18, 2020
@lifflander
#1014 dump node stats before trimming
559ff1f
lifflander pushed a commit that referenced this issue Sep 18, 2020
@lifflander
#1014 review remarks (squash before merge)
390a946
lifflander added a commit that referenced this issue Sep 18, 2020
@lifflander
#1014: runtime: check MPI_Comm for use during component startup
32b63fa
jstrzebonski pushed a commit that referenced this issue Sep 21, 2020
#1014 dump node stats before trimming
9d676d9
jstrzebonski pushed a commit that referenced this issue Sep 21, 2020
@lifflander
#1014: runtime: check MPI_Comm for use during component startup
cc3ae67
jstrzebonski pushed a commit that referenced this issue Sep 21, 2020
#1014 dump node stats even if LB was not run
ec8ab0d
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
#1014 dump node stats before trimming
ef7a932
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
@lifflander
#1014: runtime: check MPI_Comm for use during component startup
afacf60
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
#1014 dump node stats even if LB was not run
3b029d3
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
#1014 dump node stats even if LB was not run
65632e8
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
#1014 dump node stats even if LB was not run
81d7512
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
#1014 dump node stats before trimming
38d97fa
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
@lifflander
#1014: runtime: check MPI_Comm for use during component startup
fa1e6a1
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
#1014 dump node stats even if LB was not run
11333d0
jstrzebonski pushed a commit that referenced this issue Sep 30, 2020
#1014 dump node stats before trimming
dc68ff3
jstrzebonski pushed a commit that referenced this issue Sep 30, 2020
#1014 dump node stats before trimming
2441fef
jstrzebonski pushed a commit that referenced this issue Sep 30, 2020
#1014 dump node stats before trimming
eadcd84
jstrzebonski pushed a commit that referenced this issue Oct 1, 2020
#1014 dump node stats before trimming
69602f1
jstrzebonski pushed a commit that referenced this issue Oct 1, 2020
Merge pull request #1029 from DARMA-tasking/1014-fix-NodeStats-LB-sta…
472b4e2 
…t-file-output

#1014: dump node stats before trimming
bradybray pushed a commit that referenced this issue Oct 13, 2020
#1014 dump node stats before trimming
2fc377c
bradybray pushed a commit that referenced this issue Oct 15, 2020
#1014 dump node stats before trimming
2e3ef7f
bradybray pushed a commit that referenced this issue Oct 15, 2020
#1014 dump node stats before trimming
580823d
@lifflander
Copy link
Collaborator Author

@nlslatt @jstrzebonski I think we want to port this to the release branch.

@cz4rs cz4rs mentioned this issue Apr 6, 2021
Closed
@cz4rs cz4rs added 1.0.2 and removed 1.0.1 labels Apr 9, 2021
cz4rs pushed a commit that referenced this issue May 18, 2021
@cz4rs
#1014 dump node stats before trimming
e6a028c
cz4rs pushed a commit that referenced this issue May 18, 2021
@cz4rs
#1014 dump node stats before trimming
a25f456
cz4rs pushed a commit that referenced this issue May 18, 2021
@cz4rs
#1014 dump node stats before trimming
150e0eb
cz4rs added a commit that referenced this issue May 19, 2021
@cz4rs
#1014: backport: abort when --vt_lb_stats is used
5feaf96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstrzebonski jstrzebonski

Labels
1.0.2 type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1014: dump node stats before trimming DARMA-tasking/vt
3 participants
@lifflander @cz4rs @jstrzebonski