Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some LoadModel tests use default PhaseOffset #1060

Closed
PhilMiller opened this issue Sep 16, 2020 · 1 comment · Fixed by #1068
Closed

Some LoadModel tests use default PhaseOffset #1060

PhilMiller opened this issue Sep 16, 2020 · 1 comment · Fixed by #1068
Assignees

Comments

@PhilMiller
Copy link
Member

Describe the bug

A default-constructed PhaseOffset doesn't actually specify what values should be used. Default initialization maybe ends up with NEXT_PHASE and subphase 0, which is kinda surprising. This got in the way of understanding some test failures, since it accessed a subphase structure that wasn't present. Don't use the default constructed type.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • Supercomputer or desktop [e.g., Trinity, Sierra)
  • Compiler environment [e.g., clang-3.9, gcc8]
  • Libraries [e.g., mpich-2, openmpi)
  • Commit ID or release of VT [e.g., vt-1.0.0]

Additional context
Add any other context about the problem here.

@PhilMiller PhilMiller self-assigned this Sep 16, 2020
@PhilMiller
Copy link
Member Author

Fixing as part of #1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant